Repository navigation
Conversation
ml2/ovn is about to stop managing trunks whose parent LSP is type=external, which is every baremetal parent (LP #2167105). It was the only thing moving our trunks out of DOWN and claiming their subports, so do both here: ACTIVE once the parent is bound and the undersync driver's handler for the event has run, otherwise DOWN. Subports follow their trunk. A trunk on any other kind of parent stays ml2/ovn's. Undersync does not report back, so ACTIVE means a sync was requested, not that the fabric was confirmed to carry the subports. Correcting status after the fact is left to an out-of-band reconciler.
ml2/ovn wrote parent_name/tag into every baremetal trunk subport's binding profile and LSP, where they mean nothing: undersync programs the leaf switch. LP #2167105 stops it writing them but leaves the rows it already wrote, since the code that removed them on subport delete now returns early. The binding profile is the source of truth -- ml2/ovn derives the LSP's parent_name/tag from it -- so dropping those keys through Neutron makes it rewrite the LSP itself; ovn-nbctl clear only mops up what it misses. Trunk status is audit-only, as the Neutron API does not accept it.
Python test results799 tests 799 ✅ 8s ⏱️ Results for commit 95993e4. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
device_owner/statusof their subports. ml2/ovn is about to stop managing trunks whose parent LSP istype=external, which is every baremetal parent (LP #2167105). A trunk is ACTIVE once its parent is bound and the undersync driver's handler for the event has run, and DOWN otherwise. Subports follow their trunk. Trunks on any other kind of parent stay ml2/ovn's.net trunkaudit and repair.Notes
STATUS_EVENT_PRIORITY(above the undersync driver's), and a test guards that ordering.Test plan
uv run pytestinpython/neutron-understack(472 passed, 5 xfailed on existing tracked bugs)uv run ruff check/ruff format