Repository navigation
feat(ironic): panos driver base - PUC-2049 - #2338
Merged
Merged
Conversation
Python test results107 tests 107 ✅ 8s ⏱️ Results for commit 0314b83. ♻️ This comment has been updated with latest results. |
khackworth
changed the title
cardoe
reviewed
Sep 23, 2026
cardoe
left a comment
cardoe
left a comment
Contributor
There was a problem hiding this comment.
As written this driver cannot load or run. Comments inline, but the two that reshape the PR are the hardware type name and where the credentials come from.
cardoe
force-pushed
the
panos_driver_base
branch
2 times, most recently
from
October 1, 2026 20:55
d09d883 to
8b58ee5
Compare
khackworth
added a commit
that referenced
this pull request
Oct 2, 2026
Implements validation in PanosManagement to check for required management_ip parameter, addressing PR #2338 feedback. Also adds get_properties() to advertise required driver_info parameters. All tests pass (18/18).
Give the panos hardware type its own inspect and management interfaces that talk to the appliance over the PAN-OS XML API at driver_info['management_ip'], keeping the netdev no-op interfaces as fallbacks. Inspection logs in using the [netdev_panos] credentials, trying the standard, preconfig, then factory password so it works at any point in an appliance's setup, and records the model, serial, and firmware version from show system info. Model and serial set by enroll-fw are not overwritten. LLDP port discovery, HA peer discovery, initial configuration, and the cleaning steps are stubbed with their intended behavior documented. The initial configuration verify step only logs so enrollment isn't blocked; the manual clean steps fail rather than report work that wasn't done. Co-Authored-By: Doug Goldstein <doug.goldstein@rackspace.com>
Implements validation in PanosManagement to check for required management_ip parameter, addressing PR #2338 feedback. Also adds get_properties() to advertise required driver_info parameters. All tests pass (18/18).
khackworth
force-pushed
the
panos_driver_base
branch
from
October 19, 2026 16:32
dd72ea6 to
0314b83
Compare
khackworth
enabled auto-merge
October 19, 2026 16:34
cardoe
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding in the scaffolding for the PAN-OS driver.
Added in tests to accommodate what was intended. Secrets are set to soft fail if undercloud_deploy isn't released for that env.