Repository navigation
java: move CycloneDX deduplication to the coalescer - #2066
Merged
Merged
Conversation
crozzy
force-pushed
the
cyclonedx-dedupe-coalescer
branch
2 times, most recently
from
October 22, 2026 15:32
25a58ac to
6e6ff53
Compare
crozzy
changed the title
crozzy
marked this pull request as ready for review
October 22, 2026 15:33
BradLugo
reviewed
Oct 23, 2026
BradLugo
left a comment
BradLugo
left a comment
Contributor
There was a problem hiding this comment.
I'm still not totally convinced this is the correct approach. I won't block the merge, but for example, what happens if a jar replaces a build that the SBOM claims?
Contributor
Author
Like if someone later adds a JAR in the same path with the same name as the JAR in the SBOM? I guess in this situation it would be worth relying on the sha and never consulting the path |
BradLugo
reviewed
Oct 23, 2026
CycloneDX documents in one layer can describe JAR artifacts in another layer, also, CycloneDX documents embedded within JARs can describe JAR artifacts outside of those JARs. This patch moves the package deduplication down to the coalescer in order for it have the full context of all the layers before deciding which packages are duplicates. Signed-off-by: crozzy <joseph.crosland@gmail.com>
crozzy
force-pushed
the
cyclonedx-dedupe-coalescer
branch
from
October 23, 2026 15:52
6e6ff53 to
9864999
Compare
BradLugo
reviewed
Oct 23, 2026
BradLugo
approved these changes
Oct 23, 2026
Contributor
Author
|
/fast-forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CycloneDX documents in one layer can describe JAR artifacts in another layer, also, CycloneDX documents embedded within JARs can describe JAR artifacts outside of those JARs. This patch moves the package deduplication down to the coalescer in order for it have the full context of all the layers before deciding which packages are duplicates.