Repository navigation
Consolidate duplicated utilities into shared/ - #654
Merged
Merged
Conversation
… shared/ Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
escapeRegExpinshared/string-utils.jsand replace the two identical copies indatabase/qbreader/get-query.jsandget-pg-lookup.js.escapeCSVFieldinshared/string-utils.jsand replace the three separate CSV escapers (client/scripts/download.js,client/db/frequency-list/subcategory.jsx,client/play/geoword/admin/users.js). The geoword users export keeps its formula-injection guard via{ neutralizeFormulas: true }; other exports are unchanged in that respect.titleCaseinsubcategory.jsxin favor ofshared/string-utils.js.Behavior notes
\n(previouslydownload.jshandled only\n, and the geoword users export left them raw).Not changed
client/user/stats/*) still userow.join(',').users.jsstill builds its own Blob;downloadAsFileuses a data URI, which can hit size limits on large exports.Test plan
npx semistandard,npm run build🤖 Generated with Claude Code