Repository navigation
Qualcomm AI Engine Direct - Leave a constant op with a runtime value on CPU - #24053
Open
msluszniak wants to merge 1 commit into
Open
msluszniak wants to merge 1 commit into
msluszniak wants to merge 1 commit into
Conversation
…on CPU full, full_like, arange and scalar_tensor are lowered as static tensors, so they can only be delegated when their value is known ahead of time. A fill_value computed in the graph (YOLO's `torch.full(..., stride.item())`) reached op_full's torch.full call as a Node and crashed the partitioner's support check.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24053
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 7b2bf67 with merge base e6cfbf8 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
full,full_like,arangeandscalar_tensorare lowered as static tensors, but the support check accepted them even when a value was computed in the graph. Afill_valuefrom.item()(YOLO'storch.full(..., stride.item())) reachedtorch.fullinop_fullas aNodeand crashed partitioning with aTypeError. Such ops now stay on CPU.Test plan
New
test_passes.py::TestPasses::test_full_with_runtime_fill_value_stays_on_cpufails on main and passes here.test_passes.pyandrework/passes/test.pygive the same results as main; the x86-simulatorfull/full_like/arangeoperator tests pass.cc @cccclai @winskuo-quic @shewu-quic @haowhsu-quic @DannyYuyang-quic @cbilgin @abhinaykukkadapu @psiddh @nil-is-all