Repository navigation
[executorch][cuda] Run packed noncausal DFlash draft steps on the cell cache - #24036
Merged
Merged
Conversation
…l cache Pull Request resolved: #23978 MLX batches DFlash drafts by packing every owner's new target context and query block into one noncausal draft step. Let the CUDA cell cache serve the same step so the CUDA DFlash executor can reuse the off-graph KV path. - CacheGeometry::dflash_block_size (already on main) now selects a packed draft layout on CUDA: context rows commit, query rows are scratch. - CudaCellCache prepares packed draft steps (declared context + block rows per owner) and lowers the noncausal mask the draft attends with. - lower_offgraph_kv / cuda_backend learn the draft step width spec. - Drop the "DFlash is unsupported on CUDA" builder guard. ghstack-source-id: 453099239 @exported-using-ghexport Differential Revision: [D125705710](https://our.internmc.facebook.com/intern/diff/D125705710/)
pytorchbot
requested review from
larryliu0820 and
mergennachin
as code owners
October 21, 2026 06:38
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24036
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
Gasoonjia
added this pull request to stack #24044
October 21, 2026 06:44
Gasoonjia
approved these changes
Oct 21, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #23978 by @Gasoonjia
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/Gasoonjia/77/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/Gasoonjia/77/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/Gasoonjia/77/orig
Differential Revision: D125705710
@diff-train-skip-merge