Repository navigation
Preserve eager numeric parity (#24035) - #24035
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24035
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit efbfcc0 with merge base d1f7f1f ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@YIWENX14 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125556968. |
This PR needs a
|
meta-codesync
Bot
changed the title
YIWENX14
force-pushed
the
export-D125556968
branch
from
October 21, 2026 17:45
e120415 to
80f87d5
Compare
YIWENX14
added a commit
to YIWENX14/executorch
that referenced
this pull request
Oct 21, 2026
Summary: Preserve rlllama4x query scaling and weightless sandwich-norm semantics through the landed AvoEdge trainer-override path. Keep shared rlformers conversion defaults unchanged, validate legacy head-dimension fallback before division, and gate the dense ExecuTorch scaleless post-FFN norm on a dedicated AvoEdge field so Gemma2/3 shared post_ffn_norm behavior remains unchanged. Differential Revision: D125556968
YIWENX14
added a commit
to YIWENX14/executorch
that referenced
this pull request
Oct 21, 2026
Summary: Preserve rlllama4x query scaling and weightless sandwich-norm semantics through the landed AvoEdge trainer-override path. Keep shared rlformers conversion defaults unchanged, validate legacy head-dimension fallback before division, and gate the dense ExecuTorch scaleless post-FFN norm on a dedicated AvoEdge field so Gemma2/3 shared post_ffn_norm behavior remains unchanged. Differential Revision: D125556968
YIWENX14
force-pushed
the
export-D125556968
branch
from
October 21, 2026 17:46
80f87d5 to
ba471c6
Compare
YIWENX14
added a commit
to YIWENX14/executorch
that referenced
this pull request
Oct 21, 2026
Summary: Pull Request resolved: pytorch#24035 Preserve rlllama4x query scaling and weightless sandwich-norm semantics through the landed AvoEdge trainer-override path. Keep shared rlformers conversion defaults unchanged, validate legacy head-dimension fallback before division, and gate the dense ExecuTorch scaleless post-FFN norm on a dedicated AvoEdge field so Gemma2/3 shared post_ffn_norm behavior remains unchanged. Differential Revision: D125556968
YIWENX14
force-pushed
the
export-D125556968
branch
from
October 21, 2026 17:48
ba471c6 to
0bf6511
Compare
Summary: Preserve rlllama4x query scaling and weightless sandwich-norm semantics through the landed AvoEdge trainer-override path. Keep shared rlformers conversion defaults unchanged, validate legacy head-dimension fallback before division, and gate the dense ExecuTorch scaleless post-FFN norm on a dedicated AvoEdge field so Gemma2/3 shared post_ffn_norm behavior remains unchanged. Differential Revision: D125556968
YIWENX14
force-pushed
the
export-D125556968
branch
from
October 21, 2026 18:50
0bf6511 to
efbfcc0
Compare
billmguo
approved these changes
Oct 21, 2026
YIWENX14
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.