Repository navigation
[ET-VK][binary] Nest binary operator sources - #23721
Closed
pytorchbot wants to merge 1 commit into
Closed
pytorchbot wants to merge 1 commit into
pytorchbot wants to merge 1 commit into
Conversation
Pull Request resolved: #23491 ## Ulterior Motive Organize Vulkan operators by implementation family so operators with multiple routes can use clear, scalable directory layouts. ## Rationale **What**: Move standard binary GLSL, YAML, shared shader definitions, and C++ implementations into dedicated `binary/` directories. **Why**: The flat shader and implementation directories obscure ownership as operator families grow. Binary operators provide a contained validation of nested-source support before reorganizing larger families such as convolution. ## Details - Move tensor-tensor and tensor-scalar shader templates, YAML variant definitions, and `binary_op_defs.glslh` under `glsl/binary/`, and `q8ta_binary` under `glsl/binary/q8ta/`. - Move `BinaryOp.cpp` and `BinaryScalarOp.cpp` under `impl/binary/`, and the quantized `Q8taBinary.{h,cpp}` under `impl/binary/q8ta/`. - Update shader-name validation to address path-qualified template identities, the `Q8taBinary.h` include in `TestQ8taBinary.cpp`, and the binary section labels in `op_registry.py`. - Moved files are recorded as renames. - Preserve generated shader names and runtime dispatch behavior. ghstack-source-id: 446951706 @exported-using-ghexport Differential Revision: [D123101915](https://our.internmc.facebook.com/intern/diff/D123101915/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23721
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #23491 by @SS-JIA
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/658/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/658/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/657/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/658/orig
Differential Revision: D123101915
@diff-train-skip-merge