Repository navigation
[CoreAI] Remove sidecar asset delivery from the exporter - #23318
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23318
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 3 PendingAs of commit 86eadab with merge base b5aaeee ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
metascroy
marked this pull request as ready for review
October 1, 2026 17:28
SS-JIA
approved these changes
Oct 1, 2026
Summary: The Core AI runtime only loads assets embedded in the .pte, so drop sidecar delivery from the exporter: `CoreAIPartitioner(uses_sidecar=...)`, the `coreai_uses_sidecar` compile spec, `coreai_sidecar_dir` and `COREAI_SIDECAR_DIR`, and the `sidecar` / `aot_compiled_sidecar` packaging values. Source `.aimodel` and AOT-compiled `.aimodelc` bundles are always embedded via NamedDataStore. Test Plan: ``` python -m pytest backends/apple/coreai ``` 114 passed (coreai-core 1.0.0b3, coreai-torch 0.4.3). The removed tests only covered sidecar delivery.
metascroy
force-pushed
the
coreai-v2/00d-no-sidecar
branch
from
October 1, 2026 19:04
8b4ebf4 to
86eadab
Compare
This PR needs a
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Core AI runtime only loads assets embedded in the
.pte, so sidecar delivery is removed from the exporter.CoreAIPartitioner(uses_sidecar=...)and thecoreai_uses_sidecarcompile spec.coreai_sidecar_dir(also from__init__exports) andCOREAI_SIDECAR_DIR.sidecar/aot_compiled_sidecarpackaging values._deliver, along with its existing-directory guard and the "env var set but inline" warning..aimodeland AOT-compiled.aimodelcbundles are always embedded via NamedDataStore.archsmap points at embedded bundle keys, two delegates get distinct asset keys, and sizes are checked against embedded payloads.Test plan:
python -m pytest backends/apple/coreaigives 113 passed.