Skip to content

Arm backend: Register op tests with glob - #19931

Open
Sebastian-Larsson wants to merge 1 commit into
pytorch:mainfrom
Sebastian-Larsson:glob_tests
Open

Sebastian-Larsson wants to merge 1 commit into
pytorch:mainfrom
Sebastian-Larsson:glob_tests

Conversation

@Sebastian-Larsson

@Sebastian-Larsson Sebastian-Larsson commented Jun 2, 2026 •

Copy link
Copy Markdown
Collaborator

Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
Change-Id: I33a4c1e21ca9e4c22cf84ace9c62f61c563246c4
@Sebastian-Larsson Sebastian-Larsson added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate labels Jun 2, 2026
@pytorch-bot

pytorch-bot Bot commented Jun 2, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19931

Note: Links to docs will display an error until the docs builds have been completed.

❌ 13 New Failures, 1 Cancelled Job, 1 Unrelated Failure, 1 Unclassified Failure

As of commit ae0a316 with merge base f512d7e (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 2, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jun 2, 2026
@zingo zingo added the help wanted Extra attention is needed label Jun 2, 2026
@zingo

zingo commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Hi @digantdesai this will probably help some buck2 merge problems we cause, is this OK?

"ops/test_bmm.py",
"ops/test_split.py",
]
test_files += native.glob(["ops/test_*.py"])

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right direction, but I did it in a non-glob manner to make sure the new test doesn't start failing internally. Let me pull it inside and see what happens.

@meta-codesync

meta-codesync Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this in D107387455.

@digantdesai

Copy link
Copy Markdown
Contributor

Many test failures, I need to take a closer look but the right direction is to fix internal tests, and land this, just that it may take some time. :|

@digantdesai
digantdesai requested a review from rascani June 23, 2026 15:58
@digantdesai

Copy link
Copy Markdown
Contributor

@rascani FYI - we can discuss this more later.

@digantdesai

Copy link
Copy Markdown
Contributor

Sorry this is still on us.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions Bot added the Stale PRs inactive for over 60 days label Sep 7, 2026
@Sebastian-Larsson

Copy link
Copy Markdown
Collaborator Author

@digantdesai any updates on this?

@github-actions github-actions Bot closed this Oct 16, 2026
@Sebastian-Larsson

Copy link
Copy Markdown
Collaborator Author

@digantdesai now this closed as stale, are we not doing this?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. help wanted Extra attention is needed module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate Stale PRs inactive for over 60 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants