Repository navigation
Arm backend: Register op tests with glob - #19931
Sebastian-Larsson wants to merge 1 commit into
Conversation
Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com> Change-Id: I33a4c1e21ca9e4c22cf84ace9c62f61c563246c4
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19931
Note: Links to docs will display an error until the docs builds have been completed. ❌ 13 New Failures, 1 Cancelled Job, 1 Unrelated Failure, 1 Unclassified FailureAs of commit ae0a316 with merge base f512d7e ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @digantdesai this will probably help some buck2 merge problems we cause, is this OK? |
| "ops/test_bmm.py", | ||
| "ops/test_split.py", | ||
| ] | ||
| test_files += native.glob(["ops/test_*.py"]) |
There was a problem hiding this comment.
This is the right direction, but I did it in a non-glob manner to make sure the new test doesn't start failing internally. Let me pull it inside and see what happens.
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this in D107387455. |
|
Many test failures, I need to take a closer look but the right direction is to fix internal tests, and land this, just that it may take some time. :| |
|
@rascani FYI - we can discuss this more later. |
|
Sorry this is still on us. |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
@digantdesai any updates on this? |
|
@digantdesai now this closed as stale, are we not doing this? |
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @robell @rascani