Repository navigation
Mark io.Reader and io.Writer as runtime-checkable - #16888
Merged
JelleZijlstra merged 1 commit intoNov 21, 2026
Merged
Conversation
srittau
approved these changes
Nov 21, 2026
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Member
|
I also had Codex look for other similar classes (ABC at runtime, non-runtime-checkable protocol in typeshed) and it didn't find any others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark
io.Readerandio.Writeras@runtime_checkableso type checkers accept them inisinstance,issubclass, and class patterns.CPython implements both as ABCs with
__subclasshook__methods that check forreadandwrite, respectively. Thetyping_extensionsstubs already use@runtime_checkablefor the backports on Python < 3.14.Prepared with Codex.