Skip to content

Replace final FloatInt instances - #16887

Merged
srittau merged 1 commit into
python:mainfrom
srittau:final-float-int
Nov 21, 2026
Merged

srittau merged 1 commit into
python:mainfrom
srittau:final-float-int

Conversation

@srittau

@srittau srittau commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator
  • unittest.mock.ThreadingMixin.DEFAULT_TIMEOUT was marked as final by accident.
  • jenkins.DEFAULT_TIMEOUT is a sentinel, not float.
  • reportlab landscape and portrait only accept float arguments if they return only float values

- `unittest.mock.ThreadingMixin.DEFAULT_TIMEOUT` was marked as final
by accident.
- `jenkins.DEFAULT_TIMEOUT` is a sentinel, not `float`.
@srittau
srittau requested review from Akuli and Avasam as code owners November 21, 2026 12:38
@github-actions

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau
srittau merged commit 567e5e3 into python:main Nov 21, 2026
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants