Repository navigation
Remove unnecessary wrappers from _sentry_monitoring - #76
Merged
Merged
Conversation
If you initialize the SDK with no DSN, the entire module acts as a noop. We don't need our own module to implement the same logic, so remove that.
We no longer need to check for Sentry initialization since we do it unconditionally. But this does break the existing HTTPError test, so add a more specialized one.
This keeps all the Sentry reporting code in the dedicated module and lets us DRY up some of the logic.
sethmlarson
reviewed
Nov 16, 2026
sethmlarson
reviewed
Nov 16, 2026
sethmlarson
left a comment
Collaborator
There was a problem hiding this comment.
One question, otherwise LGTM.
Collaborator
Ensure the SDK does not contact a real server if the patch fails.
sethmlarson
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the Sentry SDK already noops itself when you initialize it without a DSN, rely on that and remove our own wrappers that do so.
The commits might be easier to review individually.
Closes #76.