Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions Lib/test/test_robotparser.py
Original file line number Diff line number Diff line change
Expand Up @@ -875,5 +875,23 @@ def test_read_404(self):
self.assertIsNone(parser.crawl_delay('*'))
self.assertIsNone(parser.request_rate('*'))


class RepeatedUserAgentPerformanceTest(unittest.TestCase):
"""Parsing many identical ``User-agent:`` lines must stay linear."""

def test_many_duplicate_user_agents(self):
import time
body = ("User-agent: evil\n" * 50_000) + "Disallow: /\n"
parser = urllib.robotparser.RobotFileParser()
parser.modified()
start = time.perf_counter()
parser.parse(body.splitlines())
elapsed = time.perf_counter() - start
self.assertLess(elapsed, 5.0,
f"parse of 50_000 duplicate User-agent lines "
f"took {elapsed:.3f}s")
self.assertFalse(parser.can_fetch("evil", "/"))


if __name__=='__main__':
unittest.main()
4 changes: 4 additions & 0 deletions Lib/urllib/robotparser.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,12 @@ def read(self):

def _add_entry(self, entry):
self.entries.append(entry)
seen = set()
for agent in entry.useragents:
agent = agent.lower()
if agent in seen:
continue
seen.add(agent)
if agent not in self.groups:
self.groups[agent] = entry
else:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix quadratic-time cost in :meth:`urllib.robotparser.RobotFileParser.parse` when a single group contains many identical ``User-agent:`` lines.
Loading