Repository navigation
Conversation
Contributor
Author
Closed
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To count threads for the fork
DeprecationWarning,os.fork(),os.fork1()andos.forkpty()calledtask_for_pid()andtask_threads()and releases nothing, so each call leaks a VM region and a port reference per thread.The PR instead reads
pti_threadnumfromproc_pidinfo(), so there's nothing to release.Measured with the repro from the issue, counting
Mach Messageregions withvmmap.This is going to need backport, possibly dating 3.13 or even 3.12 (security only)?
Details
I think this is the fix, given that we don't need a port, only the count.
We already use
proc_pidinfo()(available since 10.5 (2007)):cpython/Modules/_remote_debugging/subprocess.c
Line 348 in 484bc16
cpython/Modules/_remote_debugging/threads.c
Line 173 in 484bc16
That said, to be honest, the alternative fixes are:
task_for_pid()andtask_threads(), then deallocate thread ports, list, and task ports. There are three things to release and I don't think it works in the App Sandbox. Also: should we usetask_for_pid()for the self process?task_threads(mach_task_self(), ...)and deallocate thread ports and the thread list. I don't think that we could usetask_info()here?`task_threads(mach_task_self(), ...)` example
Where:
pti_threadnumfromproc_pidinfo(): KSCrash, Chromium, psutil, osquery.task_threads(mach_task_self(), ...)and deallocate: Swift, Firefox, .NET, WebKit.My other problem is that the alternatives are easy to get wrong (eg: found googletest having this problem, too.)