Repository navigation
gh-129813: Use PyBytesWriter for strided mmap slices - #162257
Merged
Merged
Conversation
Contributor
Author
|
cc @vstinner Found while checking after the |
vstinner
approved these changes
Nov 19, 2026
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. Straightforward usage of the PyBytesWriter API.
Member
Hey, it's not only a simplification, it's also a nice optimization! Reducing the peak memory usage by a factor of 2 is great! Also, the slice operation is up to 1.11x faster than before, which is also nice to have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write large strided slices directly to the result, saving one alloc + copy. The PR extends #138831 to slices such as
m[::2].This is mostly a simplification but it's good on the memory front:
m[::2]m[::2]m[::-1]m[::1](control)No regression on the performance front:
m[::2]m[::2]m[::2]m[::-1]m[::1](control)(both on macOS arm64)
Reproduce memory measurements
pyperf