Repository navigation
gh-161814: Fix Unicode property matching in case-insensitive sets - #162253
Open
sunsss123soldier wants to merge 2 commits into
Open
sunsss123soldier wants to merge 2 commits into
sunsss123soldier wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161814
In a case-insensitive character set, lowercasing the input before every check can change whether it matches a Unicode property such as
\p{Lu}. Following the approach suggested in the issue, the matcher now uses the original input for category checks and the lowercased input for literals and ranges.The regression tests cover ASCII and Unicode ignore-case modes, literals and ranges, negated character sets, and negated property escapes.
Validation
python -m test test_re(173 run, 4 skipped)patchcheck, Ruff 0.17.4, andsphinx-linton the NEWS entryCodex assisted with the tests.