Repository navigation
gh-162243: Fix shared-memory library detection with LIBS - #162244
Open
computerquip-work wants to merge 1 commit into
Open
computerquip-work wants to merge 1 commit into
computerquip-work wants to merge 1 commit into
Conversation
An existing -lrt in LIBS lets the shm_open probe succeed without recording librt for _posixshmem. The module is linked separately without LIBS, so its required library is missing on systems where libc does not provide it. Clear LIBS within the saved probe environment to determine the module's own requirements, following the curses fix in pythonGH-156130. The actual module fails to import before the fix and shared-memory operations pass afterward. The full test suite passes, and configure is regenerated with the pinned Autoconf image.
computerquip-work
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
November 18, 2026 23:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #162243.
When
LIBSalready contains-lrt, theshm_opencheck succeeds without recording-lrtfor_posixshmem. ClearLIBSjust for that check so the module gets its own required link flag, following the curses fix in #156130.The module fails to import before the fix and shared-memory operations work afterward. The full test suite passes, and
configurewas regenerated with CPython's pinned Autoconf image.