Repository navigation
gh-157227: _remote_debugging: Remove dead code for handling integer line numbers in collectors - #162241
Merged
Conversation
pablogsal
approved these changes
Nov 19, 2026
pablogsal
left a comment
Member
There was a problem hiding this comment.
LGTM! I reviewed the changes and found no problems. Thanks for the cleanup!
|
Thanks @maurycy for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-162264 is a backport of this pull request to the 3.15 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove support for bare integer frame locations from the sampling profiler’s collectors and their tests.
The live sampler produces a four-field
LocationInfo, and binary replay produces a plain four-item tuple. Both useNonewhen the location is unavailable. Only the tests supplied a bare line number.This is the follow-up requested in #157228 (comment) (I'm sorry that this one is taking so long!)
_remote_debugging:BinaryWriter.write_sample()trivial segfault #157227