Skip to content

gh-157227: _remote_debugging: Remove dead code for handling integer line numbers in collectors - #162241

Merged
pablogsal merged 1 commit into
python:mainfrom
maurycy:sampling-remove-integer-locations
Nov 19, 2026
Merged

pablogsal merged 1 commit into
python:mainfrom
maurycy:sampling-remove-integer-locations

Conversation

@maurycy

@maurycy maurycy commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Remove support for bare integer frame locations from the sampling profiler’s collectors and their tests.

The live sampler produces a four-field LocationInfo, and binary replay produces a plain four-item tuple. Both use None when the location is unavailable. Only the tests supplied a bare line number.

This is the follow-up requested in #157228 (comment) (I'm sorry that this one is taking so long!)

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I reviewed the changes and found no problems. Thanks for the cleanup!

@pablogsal
pablogsal merged commit 4cfa012 into python:main Nov 19, 2026
57 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @maurycy for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Nov 19, 2026

Copy link
Copy Markdown

GH-162264 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 19, 2026
@maurycy
maurycy deleted the sampling-remove-integer-locations branch November 19, 2026 11:35
pablogsal pushed a commit that referenced this pull request Nov 19, 2026
… collectors (GH-162241) (#162264)

Remove the integer-location branches from the sampling collectors. Live samples and binary replay use four-field locations or None.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants