Repository navigation
[3.14] gh-136267: Use the target configuration in build-details.json (GH-161529) - #162240
Merged
Merged
Conversation
…ythonGH-161529) With --with-build-python, generate-build-details.py runs on a different interpreter than the one being built. abi.flags, suffixes.extensions, abi.stable_abi_suffix and supports_isolated_interpreters came from sys and importlib, so they described the build interpreter. Read them from sysconfig instead. The extension suffix list is rebuilt the same way Python/dynload_shlib.c builds it; a test checks that the result matches importlib.machinery.EXTENSION_SUFFIXES on native builds. Also set abi.extension_suffix and abi.stable_abi_suffix for static libpython builds. They were only set with a shared libpython, but extension modules work either way and PEP 739 requires them. (cherry picked from commit fb9330b) Co-authored-by: Itamar Oren <itamarost@gmail.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Nov 18, 2026
3.14's `_PyImport_DynLoadFiletab` has no `abi3t` or platform-tagged `abi3` suffixes and no SOABI-tagged `.dll` on Cygwin, and its `sysconfig` keeps the quotes around `ALT_SOABI`. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With --with-build-python, generate-build-details.py runs on a different
interpreter than the one being built. abi.flags, suffixes.extensions,
abi.stable_abi_suffix and supports_isolated_interpreters came from sys and
importlib, so they described the build interpreter. Read them from
sysconfig instead. The extension suffix list is rebuilt the same way
Python/dynload_shlib.c builds it; a test checks that the result matches
importlib.machinery.EXTENSION_SUFFIXES on native builds.
Also set abi.extension_suffix and abi.stable_abi_suffix for static
libpython builds. They were only set with a shared libpython, but
extension modules work either way and PEP 739 requires them.
(cherry picked from commit fb9330b)
Co-authored-by: Itamar Oren itamarost@gmail.com
Co-authored-by: Claude Fable 5.1 noreply@anthropic.com