Repository navigation
gh-162230: Relay BufferedRWPair.readline() to the reader - #162231
Merged
Merged
Conversation
cmaloney
reviewed
Nov 18, 2026
cmaloney
left a comment
Contributor
There was a problem hiding this comment.
Overall looking good, I think the change in underlying calls is worth it for the performance.
Contributor
Author
|
@cmaloney Thank you for taking a look! Both comments addressed. |
cmaloney
reviewed
Nov 18, 2026
cmaloney
approved these changes
Nov 18, 2026
Contributor
|
I created gh-162246 as a meta BufferedRWPair case. Assigned to me to try and reduce PR spam, happy for others to work on it. |
|
Contributor
|
Seems to be a failure on other things. That the traceback text from buildbot is wrong is also a thing (added to my backlog). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call the internal reader's
readline()in_ioand_pyio.There is behaviour change.
BufferedRWPair.readline()would behave likeBufferedReader.readline(): in C, a non-blocking read with no data returns the partial line orb''instead of raisingOSError, a closed pair always raisesValueError, and subclass overrides ofpeek()andread()would no longer apply.io:BufferedRWPair.readline()copies the unread buffer for every line #162230