Repository navigation
gh-161924: Reject iconv encoding names with empty stripped charset - #162229
Open
Abhishekpandey123-git wants to merge 2 commits into
Open
Abhishekpandey123-git wants to merge 2 commits into
Abhishekpandey123-git wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject encoding names in
encodings.iconv_search_function()and_codecs.iconv_{encode,decode}when the charset portion before/or,contains no ASCII alphanumeric characters.Cause
glibc'siconv_open()strips trailing/,,,//SUFFIXmodifiers, and any non-ASCII-alphanumeric characters outside_-.,:, treating a resulting empty string as the current locale encoding. Names such as'!!!','@','é','한글','//', and'//TRANSLIT'previously succeeded during probing and resolved to the locale codec instead of raisingLookupError.Changes
0-9,A-Z,a-z) in the charset portion before the first/or,inLib/encodings/__init__.pyandModules/_codecsmodule.c.Lib/test/test_codecs.py(IconvTest.test_empty_stripped_charset).