Repository navigation
Conversation
… when max_length is reached
…_length and >4 GiB input
Fixes an issue where input exceeding 4 GiB was not handled correctly, leading to incorrect stream position during decompression.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
…18-22-01-00.gh-issue-162153.Zl1BmX.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a single zlib._ZlibDecompressor.decompress(data, max_length) call receives more than UINT_MAX bytes of input and reaches the output limit, decompress_buf() re-ran its outer loop and arrange_input_buffer() overwrote zst.avail_in without crediting the unconsumed remainder to avail_in_real. Only the last chunk's remainder was added back after the loop, so up to ~4 GiB of input was silently dropped: eof stayed false, needs_input became true, and feeding the rest of the stream continued at the wrong position (gh-162153).
Once the output limit is reached, no more input is needed (no inflate() runs after it), so the outer loop now stops there and the existing final add-back accounts for the unconsumed remainder. _bz2module.c handles the same structure correctly via its per-call accounting.
Testing: