Repository navigation
Conversation
This patch also calls it for extension function results, which are likely to be the commonly affected True/None/False.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's another way to help with de-immortalization: reset the refcount periodically, in GIL builds.
This isn't a complete fix as I don't think we can do it reliably. GC doesn't/shouldn't really touch immortal objects, and doing this too often
For an example, or first approximation, we can do it for extension function results (through which None/True/False are likely to go, and which are sufficiently heavy-weight operations so the assignment cost is ~noise), but there are probably other places where this would be useful.