Repository navigation
gh-162214: Test Py_GIL_DISABLED macro using #ifdef - #162223
Merged
Merged
Conversation
Replace "#if Py_GIL_DISABLED" with "#ifdef Py_GIL_DISABLED" to fix
compiler warnings when building Python with -Wundef.
Example of fixed warning:
Objects/unicodeobject.c:14740:5: warning: 'Py_GIL_DISABLED'
is not defined, evaluates to '0' [-Wundef]
14740 | #if Py_GIL_DISABLED
| ^~~~~~~~~~~~~~~
Simplify also Py_GIL_DISABLED == 0 test in PC/pyconfig.h.
vstinner
requested review from
a team,
ericsnowcurrently and
markshannon
as code owners
November 18, 2026 16:27
Member
Author
|
The macro is only defined to Corresponding code in |
zooba
approved these changes
Nov 18, 2026
Member
Author
|
Merged. Thanks for the review @zooba! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace "#if Py_GIL_DISABLED" with "#ifdef Py_GIL_DISABLED" to fix compiler warnings when building Python with -Wundef.
Example of fixed warning:
Simplify also Py_GIL_DISABLED == 0 test in PC/pyconfig.h.
-Wundefto detect typos in C macro names and detect undefined macros #162214