Repository navigation
Update Emscripten libffi to 3.8.1 - #162188
Conversation
|
Thanks Agriya! |
|
Thanks for the review! I am running tests locally on my macOS machine and I got it to crash with a |
|
Looks like it's not related, indeed, because I just rebuilt with libffi 3.4.6 (on the current Would it make sense to have a CI job that runs Emscripten tests on macos-latest, too, besides Linux? |
freakboy3742
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Would it make sense to have a CI job that runs Emscripten tests on macos-latest, too, besides Linux?
I agree this would be nice to have; but macOS runners are both expensive and in comparatively short supply, so I'm hesitant to add a new macOS CI task.
Hi! This is a tiny PR that updates the libffi version used for the Emscripten build from 3.4.6 to 3.8.1. This is a companion PR to pyodide/pyodide#6560. @hoodmane suggested that it is alright for me to upstream this here.
libffi has removed support for
-sWASM_BIGINT=0, so we can drop this flag. I did check if any tests can be updated, but it looks like we don't have any JSPI tests here, as we do in Pyodide.In Pyodide, my reason for updating libffi was mostly to bring my change libffi/libffi#1062, but that more or less only matters for builds that set
MAXIMUM_MEMORY. I only found out later that we don't do that here. So this PR is quite smaller than I expected. :)Thank you!