Repository navigation
gh-162150: Use full PyLongObject space in freelist #162173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cmaloney
wants to merge
7
commits into
python:main
Choose a base branch
from
cmaloney:int_60bit_freelist
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+34
−5
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fd470f9
gh-162150: Use full PyLongObject space in freelist
cmaloney 26ee13a
Improve phrasing
cmaloney 08daafd
Move static_assert into function to pass checker
cmaloney 4d6cddc
Keep original malloc in long_alloc; explain freelist sizing
cmaloney fdb8dc3
Merge branch 'main' into int_60bit_freelist
cmaloney 324b0d8
Check there is enough space to write MAX_DIGITS_FOR_FREELIST
cmaloney 0ddb67d
Say why the int freelist fill is there
cmaloney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
.../NEWS.d/next/Core_and_Builtins/2026-11-17-12-00-00.gh-issue-162150.F5c0cFN9.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Improve :class:`int` performance on 64-bit builds by allowing up to 60-bit ints, | ||
| which fit in existing spare space, to use the freelist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should actually be
==. While it's unlikely on 64 bit someone appears with a 1-digit PyLongObject after this change keeping to only one size of possible object in the freelist seems goodThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having
PyLong_DigitCount((PyLongObject *)self) < MAX_DIGITS_FOR_FREELISTshould not indeed not happen (could happen for subclasses, but here we are in_PyLong_ExactDealloc).Add an assert that
_PyLong_DigitCount((PyLongObject *)self) >= MAX_DIGITS_FOR_FREELIST). (the check can then be either<=or==There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't a good way to get "capacity" unfortunately without adding some significant hooks to the allocator that I don't think are worth it for this safety.
Moved so in debug builds and with ASAN enabled we write to the required freelist capacity which should help.
The check stays
<=becausePyLongObjectndigits can be shrunk during usage, but we should always havesizeof(PyLongObject)min space.