Repository navigation
_remote_debugging: Use PyBytesWriter in read_py_bytes() - #162110
Conversation
|
cc @vstinner |
pablogsal
left a comment
There was a problem hiding this comment.
Thanks! This removes the extra buffer and keeps the error cleanup correct.
|
Thanks @maurycy for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-162114 is a backport of this pull request to the 3.15 branch. |
Post-merge review: LGTM! The modified function requires less code to handle error which is a good thing! I'm not sure why the previous code used I'm surprised that such kind code is backported to 3.15 stable branch, but that it's up to @pablogsal to decide how to maintain this code in multiple branches :-) The new test_self_trace_with_empty_linetable() test seems to be unrelated |
|
@vstinner Thank you for taking a look! 💚 I'm either not sure myself why there was |
Replace manual buffer allocation, termination, and cleanup in
read_py_bytes()withPyBytesWriter. Add coverage for empty line tables.Not sure if issue worthy?