Repository navigation
gh-110891: Document PyType_GetDict() as returning a new reference - #162107
Merged
ZeroIntensity merged 1 commit intoNov 16, 2026
Merged
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Documentation build overview
|
ZeroIntensity
approved these changes
Nov 16, 2026
|
Thanks @kirtiagwl1595 for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-162133 is a backport of this pull request to the 3.15 branch. |
|
GH-162134 is a backport of this pull request to the 3.14 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyType_GetDict()returns a new reference (it calls_Py_XNewRef()), but its documentation does not say so. Similar functions such asPyType_GetName()show "Return value: New reference." because they are listed inDoc/data/refcounts.dat. This adds the missing entry, so readers know they must callPy_DECREF()on the result, which is the change the reporter asked for.This needs the skip news label (docs only).
I used Claude Code to research and draft this change; I reviewed every line.