Repository navigation
gh-162092: Fix test_check_interned() of test_capi - #162099
Conversation
Fix fresh_string() for Free Threaded build to make sure that the string is not interned. Co-authored-by: Maik Schulze <maik.schulze.cv@googlemail.com>
|
Without this change, test_check_interned() failed when running #162092 (comment). With this change, it no longer fails. |
|
@maikschulze: Can you double check that the change fix your issue? |
maikschulze
left a comment
There was a problem hiding this comment.
Yes, it fixes it, thanks!. fresh_string() is the better place.
A small typo in the new comment: "the string in interned" should be "the string is interned".
Thanks for testing.
Oops, fixed! |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-162118 is a backport of this pull request to the 3.15 branch. |
|
GH-162119 is a backport of this pull request to the 3.14 branch. |
…162118) gh-162092: Fix test_check_interned() of test_capi (GH-162099) Fix fresh_string() for Free Threaded build to make sure that the string is not interned. (cherry picked from commit f4c13c8) Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Maik Schulze <maik.schulze.cv@googlemail.com>
…162119) gh-162092: Fix test_check_interned() of test_capi (GH-162099) Fix fresh_string() for Free Threaded build to make sure that the string is not interned. (cherry picked from commit f4c13c8) Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Maik Schulze <maik.schulze.cv@googlemail.com>
Fix fresh_string() for Free Threaded build to make sure that the string is not interned.
test_capi.test_unicode.test_check_internedfails on a default build that reads a.pycwritten by a free-threaded build #162092