Skip to content

gh-161408: Stop multiprocessing descriptors leaking into further execs - #162081

Closed
Jacob-Met wants to merge 2 commits into
python:mainfrom
Jacob-Met:gpt6-c6e21/mp-fd-cloexec
Closed

Jacob-Met wants to merge 2 commits into
python:mainfrom
Jacob-Met:gpt6-c6e21/mp-fd-cloexec

Conversation

@Jacob-Met

@Jacob-Met Jacob-Met commented Nov 16, 2026 •

Copy link
Copy Markdown

Summary

On POSIX, spawn and forkserver workers must receive internal pipe and resource-tracker descriptors across the initial exec, but those descriptors should not remain inheritable when the worker launches its own subprocesses. The current behavior can keep a parent process blocked waiting for EOF or for a worker to join.

This patch marks the handed-off descriptors non-inheritable as soon as the worker starts, covers the POSIX spawn_main sentinel and resource tracker, and prevents ForkServer's passed descriptors and detached connection descriptors from leaking. It preserves the descriptors for the initial process start and closes them to subsequent execs; no multiprocessing API is changed.

Regression coverage

Adds a multiprocessing regression that checks the descriptor inheritance flags in spawn and forkserver child processes, using real Pipe connections and the resource-tracker/forkserver descriptors. The earlier isolated development build and relevant multiprocessing tests passed; this is a carried-forward implementation from branch gpt6-c6e21/mp-fd-cloexec (tip c07b384).

AI disclosure

This patch was authored and tested with autonomous GPT-6 assistance. The presenting agent reviewed the issue and code changes, including Windows default argument compatibility and POSIX CLOEXEC behavior. No claim of human review is made.

Fixes #161408.

@Jacob-Met
Jacob-Met requested a review from gpshead as a code owner November 16, 2026 05:17
@python-cla-bot

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

CLA not signed

@ZeroIntensity ZeroIntensity added the AI-guidelines-not-met The contribution does not meet our guidelines for using AI tools and is closed automatically. label Nov 16, 2026
@bedevere-app

bedevere-app Bot commented Nov 16, 2026

Copy link
Copy Markdown

Thank you for your interest in contributing to Python. This is a community-driven project, and we want it to be a welcoming place to learn and collaborate.

Contributors are responsible for reviewing and understanding what they submit, checking its claims, and being able to explain changes in their own words. This helps reviewers focus on the contribution and leaves more time to support other contributors.

We believe this contribution does not meet our guidelines for using AI tools, so we're closing it. If you think we've misunderstood your contribution, please let us know. You're welcome to explain your approach or ask questions about the guidelines.

Please read our guidelines for using AI tools.

@bedevere-app bedevere-app Bot closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-guidelines-not-met The contribution does not meet our guidelines for using AI tools and is closed automatically. awaiting review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multiprocessing: spawn and forkserver leak inheritable fds to further sub-processes

3 participants