Repository navigation
gh-157747: Document that ** unpacking accepts any object with keys() - #162076
Open
themythofsisyphusjayant wants to merge 1 commit into
Open
themythofsisyphusjayant wants to merge 1 commit into
themythofsisyphusjayant wants to merge 1 commit into
Conversation
themythofsisyphusjayant
requested review from
AA-Turner and
willingc
as code owners
November 16, 2026 02:52
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Language Reference said
**unpacking, in both dictionary displays and calls, requires the expression to evaluate to amapping— and the glossary defines a mapping as something implementing the fullcollections.abc.MappingABC. At runtime CPython only callskeys()and then__getitem__(), so objects like a pandas DataFrame work fine even though they are not mappings.This rewords both places in
Doc/reference/expressions.rstto match what the interpreter does, using the same wording as thedictconstructor docs: the expression must evaluate to an object that defines akeys()method, with values obtained by calling__getitem__()with each returned key. A mapping satisfies this, but any object with those two methods does.Checked by building the page with Sphinx (9.1.1, from
Doc/requirements.txt): the page renders with the new wording at both spots. The only build warnings are pre-existing single-file-build artifacts, identical before and after the change.Disclosure: I used an AI coding assistant to help prepare this change, and reviewed the diff myself before submitting.
fn(**kwargs)should acceptSupportsKeysAndGetitemand not justMapping#157747