Skip to content

[3.14] gh-161262: Fix test_touch_common flake on Emscripten (GH-161464) - #162026

Merged
cmaloney merged 1 commit into
python:3.14from
miss-islington:backport-cc98745-3.14
Nov 14, 2026
Merged

cmaloney merged 1 commit into
python:3.14from
miss-islington:backport-cc98745-3.14

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Under Node, NODEFS takes a new file's mtime from the host kernel but
utime(path, None) uses Date.now() written back via fs.utimesSync, which
can land a millisecond before the creation time. Take the baseline from
utime(path, None) too, so both timestamps come from the same source.
(cherry picked from commit cc98745)

Co-authored-by: Cody Maloney cmaloney@users.noreply.github.com
Co-authored-by: Claude Opus 5.5 noreply@anthropic.com

…161464)

Under Node, NODEFS takes a new file's mtime from the host kernel but
utime(path, None) uses Date.now() written back via fs.utimesSync, which
can land a millisecond before the creation time.  Take the baseline from
utime(path, None) too, so both timestamps come from the same source.
(cherry picked from commit cc98745)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@bedevere-app bedevere-app Bot added skip news tests Tests in the Lib/test dir labels Nov 14, 2026
@cmaloney
cmaloney enabled auto-merge (squash) November 14, 2026 22:35
@cmaloney
cmaloney merged commit 44e3be0 into python:3.14 Nov 14, 2026
54 checks passed
@miss-islington
miss-islington deleted the backport-cc98745-3.14 branch November 14, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants