Skip to content

gh-161934: Split TextIOWrapper.write into text and byte helpers - #161991

Merged
methane merged 2 commits into
python:mainfrom
methane:codex/textio-write-split
Nov 16, 2026
Merged

methane merged 2 commits into
python:mainfrom
methane:codex/textio-write-split

Conversation

@methane

@methane methane commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

@cmaloney cmaloney left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 overall; I have a slight preference for keeping the PyObject return because I find that easier to follow than int returns. It may make sense to validate the bytes are actually available/cached in the unicode path.

Comment thread Modules/_io/textio.c Resolved
@methane
methane merged commit 7c59816 into python:main Nov 16, 2026
53 of 54 checks passed
@methane
methane deleted the codex/textio-write-split branch November 16, 2026 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news topic-IO type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants