Skip to content

[3.14] gh-158907: Do not send proxy credentials to a direct origin on 407 (GH-158956) - #161920

Merged
orsenthil merged 1 commit into
python:3.14from
miss-islington:backport-ab48ba8-3.14
Nov 16, 2026
Merged

orsenthil merged 1 commit into
python:3.14from
miss-islington:backport-ab48ba8-3.14

Conversation

@miss-islington

Copy link
Copy Markdown
Contributor

ProxyBasicAuthHandler and ProxyDigestAuthHandler looked up passwords with the scheme-less origin host, so an HTTP 407 could match credentials stored for HTTPS and retry in cleartext.


(cherry picked from commit ab48ba8)

Co-authored-by: rajorin 167426833+rajorin@users.noreply.github.com
Co-authored-by: Senthil Kumaran senthil@python.org

…407 (pythonGH-158956)

* pythongh-158907: Do not send proxy credentials to a direct origin on 407

ProxyBasicAuthHandler and ProxyDigestAuthHandler looked up passwords with the scheme-less origin host, so an HTTP 407 could match credentials stored for HTTPS and retry in cleartext.

---------
(cherry picked from commit ab48ba8)

Co-authored-by: rajorin <167426833+rajorin@users.noreply.github.com>
Co-authored-by: Senthil Kumaran <senthil@python.org>
@python-cla-bot

python-cla-bot Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@orsenthil
orsenthil enabled auto-merge (squash) November 13, 2026 01:44
@StanFromIreland

Copy link
Copy Markdown
Member

@rajorin can you please sign the CLA again, you can read more about why this is necessary in the devguide.

@orsenthil
orsenthil merged commit b92dbe9 into python:3.14 Nov 16, 2026
56 checks passed
@miss-islington
miss-islington deleted the backport-ab48ba8-3.14 branch November 16, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants