Repository navigation
[3.15] gh-127172: Honor umask and default ACL when installing venv activation scripts (GH-154850) - #161856
Open
miss-islington wants to merge 1 commit into
Open
[3.15] gh-127172: Honor umask and default ACL when installing venv activation scripts (GH-154850)#161856miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
…ivation scripts (pythonGH-154850) venv wrote the activation scripts with a fixed mode copied from the packaged templates, so they ignored the process umask and any default ACL, unlike every other file venv creates. Copy only the data and let the new files inherit the umask and ACL. (cherry picked from commit 1086205) Co-authored-by: tonghuaroot (童话) <tonghuaroot@gmail.com>
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
venv wrote the activation scripts with a fixed mode copied from the packaged
templates, so they ignored the process umask and any default ACL, unlike every
other file venv creates. Copy only the data and let the new files inherit the
umask and ACL.
(cherry picked from commit 1086205)
Co-authored-by: tonghuaroot (童话) tonghuaroot@gmail.com