Repository navigation
Conversation
vstinner
reviewed
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #161691
Memoryview could still be used after Python code released it in the middle of an operation. Two spots were missing the re-check that gh-92888 added elsewhere:
m == objwhereobj.__buffer__releasesm: we testedmbefore callingPyObject_GetBufferon the other side and never again after. Now ifmgot released we just say not equal, same as any other released view.m[key] = b"x"with format'c', wherekey.__index__releasesm: every other format re-checks after converting the value, but'c'doesn't convert anything, so it never re-checked. I added the sameCHECK_RELEASED_INT_AGAINthere.On main this doesn't segfault anymore, since gh-127716 keeps the buffer alive while the operation runs. You still get wrong results: the released view compares by content, and the
'c'write goes through. On 3.15 both repros from the issue segfault. I checked that this patch applies cleanly there and fixes both.I flipped one assert in
test_gc_cleared_view. It was checking that a view cleared inside__buffer__still compares equal, which is exactly the bug here.