Repository navigation
gh-161707: Refuse ; in all cookie attributes except Comment - #161711
Conversation
Documentation build overview
46 files changed ·
|
This makes the API easier to use well: the caller and the validator don't both have to call `key.lower()`.
sethmlarson
left a comment
There was a problem hiding this comment.
Implementation LGTM, one comment on the documentation.
|
@vstinner You reviewed my previous change in this area, could I ask for a second-set of eyes? |
vstinner
left a comment
There was a problem hiding this comment.
Mostly LGTM, I have a few minor suggestions.
Co-authored-by: Victor Stinner <vstinner@python.org>
|
All those changes sound good to me, thanks. I've updated the branch. |
orsenthil
left a comment
There was a problem hiding this comment.
LGTM.
Rebase against the main will get CI to green here.
sethmlarson
left a comment
There was a problem hiding this comment.
LGTM, thanks! Will merge once CI is all green.
|
readthedocs CI appears to be stuck. GitHub is waiting for status but the details say it was aborted early for inactivity (?). |
|
It’s fine to merge, RTD can be flakey like this, but the docs CI passed. |
|
Thanks @brettcs for the PR, and @sethmlarson for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @brettcs for the PR, and @sethmlarson for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Thanks @brettcs for the PR, and @sethmlarson for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @brettcs for the PR, and @sethmlarson for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @brettcs for the PR, and @sethmlarson for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
Sorry, @brettcs and @sethmlarson, I could not cleanly backport this to Please backport manually with cherry_picker, see the devguide for more information. |
|
Sorry, @brettcs and @sethmlarson, I could not cleanly backport this to Please backport manually with cherry_picker, see the devguide for more information. |
|
Sorry, @brettcs and @sethmlarson, I could not cleanly backport this to Please backport manually with cherry_picker, see the devguide for more information. |
|
GH-161894 is a backport of this pull request to the 3.15 branch. |
|
GH-161893 is a backport of this pull request to the 3.14 branch. |
|
GH-161901 is a backport of this pull request to the 3.13 branch. |
|
GH-161902 is a backport of this pull request to the 3.12 branch. |
|
GH-161903 is a backport of this pull request to the 3.11 branch. |
See #161707 (comment) for an explanation of why I chose this approach.