Repository navigation
Conversation
Documentation build overview
61 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SMTP.verify()andSMTP.expn()always encoded their argument as ASCII, so a non-ASCII address raisedUnicodeEncodeErroreven on servers advertisingSMTPUTF8.This PR adds a
smtputf8parameter to both methods.SMTPUTF8parameter (RFC 6531 #3.7.4.2), EHLO is negotiated first if needed.SMTPNotSupportedErroris raised if the server does not advertise the extension.I used an explicit flag rather than auto-detection, mirroring
mail().For a non-ASCII address the flag is clearly needed, but it also matters for an ASCII address:
the
SMTPUTF8parameter tells the server that UTF-8 is acceptable in the reply, soVRFY joe@example.com SMTPUTF8can return250 Jő Smith <joe@example.com>, where without the parameter the server must answer 252 or 550 instead.