Skip to content

gh-160669: Clarify PyDict_Update docs - #161314

Merged
sobolevn merged 7 commits into
python:mainfrom
sobolevn:issue-160669
Nov 14, 2026
Merged

sobolevn merged 7 commits into
python:mainfrom
sobolevn:issue-160669

Conversation

@sobolevn

@sobolevn sobolevn commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

@read-the-docs-community

read-the-docs-community Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #35667453 | 📁 Comparing da23ca0 against main (f88565b)

  🔍 Preview build  

27 files changed · ± 27 modified

± Modified

Comment thread Doc/c-api/dict.rst Resolved
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Comment thread Doc/c-api/dict.rst Resolved
Comment thread Doc/c-api/dict.rst Resolved
Co-authored-by: Victor Stinner <vstinner@python.org>
Comment thread Doc/c-api/dict.rst Resolved

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now confused. The PR doesn't seem to change the text anymore, it just reformats it. Did I miss something?

@sobolevn

sobolevn commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@vstinner it is still better, because now it is clear what "except ... doesn't fall back to the iterating over a sequence of key value pairs" part relates to :)

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner it is still better, because now it is clear what "except ... doesn't fall back to the iterating over a sequence of key value pairs" part relates to :)

Ok. But then maybe don't call this PR "Fix PyDict_Update docs", but something more like "Clarify PyDict_Update docs" instead.

@sobolevn sobolevn changed the title gh-160669: Fix PyDict_Update docs gh-160669: Clarify PyDict_Update docs Nov 4, 2026
Comment thread Doc/c-api/dict.rst Resolved
Comment thread Doc/c-api/dict.rst Resolved
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@sobolevn
sobolevn merged commit 797087c into python:main Nov 14, 2026
30 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Nov 14, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Nov 14, 2026

Copy link
Copy Markdown

GH-161983 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 14, 2026
@bedevere-app

bedevere-app Bot commented Nov 14, 2026

Copy link
Copy Markdown

GH-161984 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 14, 2026
sobolevn added a commit that referenced this pull request Nov 14, 2026
gh-160669: Clarify `PyDict_Update` docs (GH-161314)
(cherry picked from commit 797087c)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
sobolevn added a commit that referenced this pull request Nov 14, 2026
gh-160669: Clarify `PyDict_Update` docs (GH-161314)
(cherry picked from commit 797087c)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants