Repository navigation
gh-160284: Number each keyword once in the PEG generator - #160290
Merged
Merged
Conversation
KeywordCollectorVisitor checked the quoted spelling of a keyword against keys stored without quotes, so the check never matched and every occurrence of a keyword in the grammar took a new token type. The 35 hard keywords were numbered between 500 and 721 instead of 500 to 534.
pablogsal
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KeywordCollectorVisitorchecked the quoted spelling of a keyword against keys stored without quotes, so the check never matched and every occurrence of a keyword in the grammar took a new token type. The 35 hard keywords were numbered between 500 and 721 instead of 500 to 534.