Repository navigation
Conversation
lkk7
commented
Jul 15, 2026
|
This PR is stale because it has been open for 90 days with no activity. |
…ite-completer-quotes
tanloong
reviewed
Nov 16, 2026
…-M37F.rst Co-authored-by: Tan Long <tanloong@foxmail.com>
tanloong
reviewed
Nov 16, 2026
tanloong
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Let's wait for erlend-aasland's review since he maintains this module. He may want changes, in which case I'm sorry if I suggested something wrong.
Contributor
Author
|
@encukou, would you have time to review this small thing? It's been waiting for Erlend's review for a few months but he seems inactive in CPython (sorry if I'm mistaken!). I see there are no other code owners for sqlite3 but you made some changes to this file, so I thought that you'd be the qualified person to contact. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153768
Attached database names can contain
"or'quotes, and it breaks table completion.Escape schema names as SQL identifiers or string literals, and add tests for both cases.