Skip to content

gh-153768: Fix sqlite3 CLI completion for database names with quotes - #153770

Open
lkk7 wants to merge 4 commits into
python:mainfrom
lkk7:fix-sqlite-completer-quotes
Open

lkk7 wants to merge 4 commits into
python:mainfrom
lkk7:fix-sqlite-completer-quotes

Conversation

@lkk7

@lkk7 lkk7 commented Jul 15, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #153768

Attached database names can contain " or ' quotes, and it breaks table completion.
Escape schema names as SQL identifiers or string literals, and add tests for both cases.

Comment thread Lib/test/test_sqlite3/test_cli.py Resolved
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Oct 18, 2026
@python-cla-bot

python-cla-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

…-M37F.rst

Co-authored-by: Tan Long <tanloong@foxmail.com>
@lkk7
lkk7 requested a review from tanloong November 16, 2026 12:29

@tanloong tanloong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's wait for erlend-aasland's review since he maintains this module. He may want changes, in which case I'm sorry if I suggested something wrong.

@lkk7

lkk7 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor Author

@encukou, would you have time to review this small thing? It's been waiting for Erlend's review for a few months but he seems inactive in CPython (sorry if I'm mistaken!).

I see there are no other code owners for sqlite3 but you made some changes to this file, so I thought that you'd be the qualified person to contact.

Thanks.

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sqlite3 completion fail on attached names with quotes

2 participants