Skip to content

gh-149217: Avoid adding dependencies on immutable, immortal classes in the JIT - #149256

Merged
markshannon merged 2 commits into
python:mainfrom
Wulian233:watch_type
May 3, 2026
Merged

markshannon merged 2 commits into
python:mainfrom
Wulian233:watch_type

Conversation

@Wulian233

@Wulian233 Wulian233 commented May 2, 2026 •

Copy link
Copy Markdown
Contributor

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produces better code, and is net -4 lines 🙂

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there is some code that should be removed.
Will be good once that's done.

Comment thread Python/optimizer_bytecodes.c Resolved
Comment thread Python/optimizer_bytecodes.c Resolved
Comment thread Python/optimizer_bytecodes.c Resolved
@bedevere-app

bedevere-app Bot commented May 2, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@read-the-docs-community

Copy link
Copy Markdown

@markshannon
markshannon self-requested a review May 3, 2026 10:05

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@markshannon
markshannon merged commit 8a7edda into python:main May 3, 2026
72 of 73 checks passed
@Wulian233
Wulian233 deleted the watch_type branch May 3, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants