Repository navigation
Conversation
| 'Op': mapping['p'], | ||
| 'W': mapping['U'].replace('U', 'W'), | ||
| }) | ||
| mapping['W'] = mapping['U'].replace('U', 'W') |
There was a problem hiding this comment.
I also brought this dictionary update into the update above it for greater stylistic consistency.
|
Tests and patchcheck re-verified before pushing merged main. Congrats on the promotion, @StanFromIreland! |
|
Lint is failing in the CI. And, to be honest I don’t really see any benefit in running patchcheck, I would recommend you run pre-commit (lint) instead. I hope to review in a few days. |
Co-authored-by: Stan Ulbrych <stan@python.org>
|
Thank you, @StanFromIreland, all requests were implemented! |
|
Keeping current with upstream. |
|
@StanFromIreland I think this is in a good place after the simplification from two months ago. |
Documentation build overview
478 files changed ·
|
|
Thank you, @StanFromIreland, that further strengthened the implementation. All changes have been made, as requested. |
|
Hi @StanFromIreland, this is ready for another round of review after the implemented changes from May 22. |
|
This PR is stale because it has been open for 90 days with no activity. |
|
Hi @StanFromIreland, this is ready for another round of review after the implemented changes from May 22, but has gone stale. We only have a couple more of these to do to complete the C99+ support. |
| 'y': r"(?P<y>\d\d)", | ||
| 'Y': r"(?P<Y>\d\d\d\d)", | ||
| # follow C99 specification of parsing up to two digits for | ||
| # first hundred centuries, without requiring zero-padding |
There was a problem hiding this comment.
Thinking about this, I fear not requiring padding may be messy for users since our parser is greedy. I suggest we require them.
There was a problem hiding this comment.
The current expression, (?P<C>\d{1,2}) is consistent with C's strptime and the C99+ specification allowing a leading zero but not requiring it. I can easily change it to (?P<C>\d{2}) and specify that leading zeros are required, but again, this will then be inconsistent with C99. Would you still like to proceed with the suggested change?
Incrementally builds C99+ datetime support with addition of
%C. Also adds tests (for%Cand for%ywith%C) and updates documentation.Continued effort from PR: #140647, #144819, #144896.
Documentation drops (0) footnote and notes that zero-padded century numbers are optional (for centuries 0 to 99).
Passed all tests.
Passed patchcheck.
Issue: #140715
str*timeto C11 format codes #140715📚 Documentation preview 📚: https://cpython-previews--145955.org.readthedocs.build/