Skip to content

_GUARD_DORV_VALUES_INST_ATTR_FROM_DICT and _CHECK_MANAGED_OBJECT_HAS_VALUES should be merged. #152066

Closed

Description

@markshannon

These two uops do exactly the same, both checking the validity of an object's inline values.
The context in which they are used differs slightly, but having distinct uops just bloats the code.

Linked PRs

Activity

  1. added
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    type-refactorCode refactoring (with no changes in behavior)
    3.16new features, bugs and security fixes
    on Jun 24, 2026
  2. markshannon commented on Jun 24, 2026

    @markshannon
    MemberAuthor

    It might make sense to fix this at the same time as #152063

  3. Aniketsy commented on Jun 25, 2026

    @Aniketsy
    Contributor

    I was working on this

    It might make sense to fix this at the same time as #152063

    should i cover the fix for this in same PR, or we can have this fix in follow up?

  4. added a commit that references this issue on Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.16new features, bugs and security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)type-refactorCode refactoring (with no changes in behavior)

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions