Skip to content

Change ADD_OP(_POP_TOP, ...) to optimize_pop_top in optimizer_bytecodes.c #148604

Closed

Description

@Fidget-Spinner

Feature or enhancement

Proposal:

See for example the following code:
https://github.com/python/cpython/blob/main/Python/optimizer_bytecodes.c#L863

Should replace this:
https://github.com/python/cpython/blob/main/Python/optimizer_bytecodes.c#L1905

We should be careful to pass in the correct argument.

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs

Activity

  1. cocolato commented on Apr 15, 2026

    @cocolato
    Member

    I can do it, but if others want to do it, please feel free to claim it.

  2. Fidget-Spinner commented on Apr 15, 2026

    @Fidget-Spinner
    MemberAuthor

    @NekoAsakura would you like to take this up? I'm going to discuss how to handle the other issue on trace recording later with Mark, so for now, if you'd like to you can work on something else.

  3. NekoAsakura commented on Apr 15, 2026

    @NekoAsakura
    Member

    Sure.

  4. added 2 commits that reference this issue on Apr 15, 2026
  5. added a commit that references this issue on Apr 15, 2026
  6. added a commit that references this issue on Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    interpreter-core(Objects, Python, Grammar, and Parser dirs)topic-JITtype-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions