Skip to content

Should frozendict be added to Argument Clinic? #145079

Closed as not planned
Closed as not planned

Description

@johnslavik

Feature or enhancement

Proposal:

We already have a set+frozenset pair, so it seems sensible to add &PyFrozenDict_Type check alongside already present &PyDict_Type check. Unless we shouldn't add it until there is a strong existing practical use case?

Slightly offtopic, I believe it would be even better if we had a generic PyAnyDict_Check "picklock" in AC but this is no longer a converter and I'm not sure it's inline with what AC is supposed to do. I am thinking about it mainly in the context of #145076 which can just be solved with a manual if-check.

cc @vstinner

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Activity

  1. changed the title [-]Should `frozendict` be added to Argument Clinic type checks?[/-] [+]Should `frozendict` be added to Argument Clinic?[/+] on Feb 21, 2026
  2. vstinner commented on Feb 21, 2026

    @vstinner
    Member

    Can you explain your use case? Which functions do you want to modify to support frozendict?

  3. johnslavik commented on Feb 21, 2026

    @johnslavik
    MemberAuthor

    I don't have a strong use case myself (Unless we shouldn't add it until there is a strong existing practical use case?), but I thought it would be nice to ask if it's desired that it is added.

  4. johnslavik commented on Feb 21, 2026

    @johnslavik
    MemberAuthor

    Sorry, maybe I'll just reopen if there is a use case.

    This was more of a question than a feature request. My intention was to collect feedback, check if others would think it is useful or useful in the future. Maybe I shouldn't have opened this issue, DPO just didn't fit in my mind. There is a section Core Development, so maybe I'll ask there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions