Skip to content

gh-727: Add type-security to PRs with security blurbs - #728

Merged
StanFromIreland merged 1 commit into
python:mainfrom
brettcs:add-type-security
Nov 10, 2026
Merged

StanFromIreland merged 1 commit into
python:mainfrom
brettcs:add-type-security

Conversation

@brettcs

@brettcs brettcs commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7b98afb) to head (3115c6d).

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #728   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2520      2544   +24     
  Branches       125       127    +2     
=========================================
+ Hits          2520      2544   +24     
Flag Coverage Δ
Python_3.14.10 100.00% <100.00%> (ø)
Python_3.15.2 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
bedevere/prtype.py 100.00% <100.00%> (ø)
tests/test_prtype.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread bedevere/prtype.py
await gh.post(issue["labels_url"], data=label_names)


async def classify_by_filepaths(gh, pull_request, filenames):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only runs when the PR is opened, which isn't ideal:

if event.data["action"] == "opened":
labels = await prtype.classify_by_filepaths(gh, pull_request, filenames)

Although I think in general we'll be adding them before creating the issue, so I think we can leave it as-is.

@StanFromIreland StanFromIreland changed the title Add type-security to PRs with security blurbs (#727) gh-727: Add type-security to PRs with security blurbs Nov 10, 2026
@StanFromIreland

Copy link
Copy Markdown
Member

For titles, please put the issue at the start (or in the PR body, either is fine in this repository), otherwise it looks like a PR number as that's where GitHub usually appends it for commits.

@StanFromIreland
StanFromIreland merged commit 767f440 into python:main Nov 10, 2026
5 of 7 checks passed
@brettcs

brettcs commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

Ohhhh I see now. I keep looking at the Git log for guidance on how I should format titles but that's exactly the wrong thing to do. That tells me what GitHub is doing and I need to format the title to work well within that system. Okay, gotcha.

@brettcs
brettcs deleted the add-type-security branch November 10, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants