Repository navigation
Add attrs usage notes to contributor guide - #3598
Closed
swastiktawate wants to merge 1 commit into
Closed
swastiktawate wants to merge 1 commit into
swastiktawate wants to merge 1 commit into
Conversation
Author
|
Hi, I noticed all three of my PRs were closed. Could you let me know the reason? I want to understand what was wrong with them so I can do the work properly. |
Contributor
|
LLM generated docs are not useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3116.
Adds a short "Using attrs" section to the contributor guide. It covers why Trio uses attrs, the underscore plus alias convention for constructor arguments, and when to use slots=False, eq=False and @attrs.frozen. Each point is based on the current code, for example NurseryManager for slots=False and the Statistics classes for @attrs.frozen.
Docs only, no code changes.