Skip to content

Drop support for py310 - #3594

Open
EmmanuelNiyonshuti wants to merge 10 commits into
python-trio:mainfrom
EmmanuelNiyonshuti:drop-py310
Open

EmmanuelNiyonshuti wants to merge 10 commits into
python-trio:mainfrom
EmmanuelNiyonshuti:drop-py310

Conversation

@EmmanuelNiyonshuti

Copy link
Copy Markdown
Contributor

Bumping minimum Python version to 3.11. LMK about anything I might have missed.

@codecov

codecov Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.96930%. Comparing base (7e0dc2d) to head (f89901c).
⚠️ Report is 2 commits behind head on main.

❌ Your project check has failed because the head coverage (99.96930%) is below the target coverage (100.00000%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main       #3594         +/-   ##
===================================================
+ Coverage   98.16743%   99.96930%   +1.80187%     
===================================================
  Files            128         128                 
  Lines          19972       19546        -426     
  Branches        1399        1294        -105     
===================================================
- Hits           19606       19540         -66     
+ Misses           359           2        -357     
+ Partials           7           4          -3     
Files with missing lines Coverage Δ
src/trio/_abc.py 100.00000% <100.00000%> (ø)
src/trio/_channel.py 100.00000% <100.00000%> (+2.91970%) ⬆️
src/trio/_core/_asyncgens.py 100.00000% <100.00000%> (+1.28204%) ⬆️
src/trio/_core/_entry_queue.py 100.00000% <100.00000%> (ø)
src/trio/_core/_exceptions.py 100.00000% <100.00000%> (ø)
src/trio/_core/_ki.py 100.00000% <100.00000%> (+0.93457%) ⬆️
src/trio/_core/_run.py 100.00000% <ø> (+0.84269%) ⬆️
src/trio/_core/_tests/test_asyncgen.py 100.00000% <100.00000%> (ø)
src/trio/_core/_tests/test_exceptiongroup_gc.py 100.00000% <ø> (ø)
src/trio/_core/_tests/test_ki.py 100.00000% <100.00000%> (+6.89655%) ⬆️
... and 24 more

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EmmanuelNiyonshuti

Copy link
Copy Markdown
Contributor Author

All of these tests passes locally? I suspect one particular test failing.

@EmmanuelNiyonshuti

Copy link
Copy Markdown
Contributor Author

All of these tests passes locally? I suspect one particular test failing.

Ah, I can reproduce! forgot --runs-slow

@EmmanuelNiyonshuti

Copy link
Copy Markdown
Contributor Author

switching back to using Unpack in:

def run_sync_soon(
self,
sync_fn: Callable[[Unpack[PosArgsT]], object],
*args: Unpack[PosArgsT],
idempotent: bool = False,

does jedi not support * syntax?

@TeamSpen210

Copy link
Copy Markdown
Contributor

Not sure why you're mass-replacing NoReturn with Never - they are synonyms, but the former is more readable for function return values.

@EmmanuelNiyonshuti

Copy link
Copy Markdown
Contributor Author

Not sure why you're mass-replacing NoReturn with Never - they are synonyms, but the former is more readable for function return values.

Yes, but it's the preferred type to use moving forward for this.

Comment thread pyproject.toml

# conflicts with formatter (ruff recommends these be disabled)
"missing-trailing-comma", # COM812
"non-pep646-unpack" # (UP044) ignoring it for now(See: https://github.com/python-trio/trio/pull/3594#issuecomment-6898086470)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed once jedi supports * unpack operator.

@EmmanuelNiyonshuti

Copy link
Copy Markdown
Contributor Author

Not sure why you're mass-replacing NoReturn with Never - they are synonyms, but the former is more readable for function return values.

d097f18

- update requirements files
- remove tomli additional dependency in pre-commit config
- bump remaining python references to 3.11
@EmmanuelNiyonshuti

Copy link
Copy Markdown
Contributor Author

Sorry, my commits history got a little messy on this one!

@A5rocks A5rocks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm sure we will have a few follow ups (for example to process the strict exception groups deprecation), but this seems good.

Comment thread src/trio/_core/_run.py Resolved
Comment thread src/trio/_tests/test_repl.py Resolved
Comment thread src/trio/_tests/test_repl.py Resolved
Comment thread src/trio/_subprocess.py Resolved
Comment thread src/trio/_ssl.py Resolved
Comment thread tox.ini Resolved
@EmmanuelNiyonshuti

Copy link
Copy Markdown
Contributor Author

Thanks! I'm sure we will have a few follow ups (for example to process the strict exception groups deprecation), but this seems good.

Yeah, probably.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants