Repository navigation
Drop support for py310 - #3594
EmmanuelNiyonshuti wants to merge 10 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (99.96930%) is below the target coverage (100.00000%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3594 +/- ##
===================================================
+ Coverage 98.16743% 99.96930% +1.80187%
===================================================
Files 128 128
Lines 19972 19546 -426
Branches 1399 1294 -105
===================================================
- Hits 19606 19540 -66
+ Misses 359 2 -357
+ Partials 7 4 -3
🚀 New features to boost your workflow:
|
|
All of these tests passes locally? I suspect one particular test failing. |
Ah, I can reproduce! forgot --runs-slow |
|
switching back to using Unpack in: trio/src/trio/_core/_entry_queue.py Lines 174 to 178 in 7e0dc2d does jedi not support * syntax? |
|
Not sure why you're mass-replacing |
Yes, but it's the preferred type to use moving forward for this. |
|
|
||
| # conflicts with formatter (ruff recommends these be disabled) | ||
| "missing-trailing-comma", # COM812 | ||
| "non-pep646-unpack" # (UP044) ignoring it for now(See: https://github.com/python-trio/trio/pull/3594#issuecomment-6898086470) |
There was a problem hiding this comment.
This should be removed once jedi supports * unpack operator.
|
- update requirements files - remove tomli additional dependency in pre-commit config - bump remaining python references to 3.11
|
Sorry, my commits history got a little messy on this one! |
A5rocks
left a comment
There was a problem hiding this comment.
Thanks! I'm sure we will have a few follow ups (for example to process the strict exception groups deprecation), but this seems good.
Yeah, probably. |
Bumping minimum Python version to 3.11. LMK about anything I might have missed.